Skip to content

[anneal] Adopt Lake artifact cache and share packages in workspace generation#3298

Open
joshlf wants to merge 1 commit intomainfrom
Gvp53yva2aqbllig3wjytgakvxxqrmdhx
Open

[anneal] Adopt Lake artifact cache and share packages in workspace generation#3298
joshlf wants to merge 1 commit intomainfrom
Gvp53yva2aqbllig3wjytgakvxxqrmdhx

Conversation

@joshlf
Copy link
Copy Markdown
Member

@joshlf joshlf commented Apr 19, 2026

This change incrementally adopts the Lake artifact cache for integration tests
and workspace generation, avoiding redundant clones and builds.

  • During setup, populates Lake's artifact cache in the toolchain directory.
  • During workspace generation, copies lake-manifest.json from the
    toolchain and patches it to include the aeneas dependency.
  • Symlinks the toolchain's .lake/packages directory into the generated
    workspace to share source checkouts.

Latest Update: v3 — Compare vs v2

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v2 v1 Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gvp53yva2aqbllig3wjytgakvxxqrmdhx && git checkout -b pr-Gvp53yva2aqbllig3wjytgakvxxqrmdhx FETCH_HEAD

Checkout

git fetch origin refs/heads/Gvp53yva2aqbllig3wjytgakvxxqrmdhx && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gvp53yva2aqbllig3wjytgakvxxqrmdhx && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gvp53yva2aqbllig3wjytgakvxxqrmdhx

Stacked PRs enabled by GHerrit.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.88%. Comparing base (c97dbc6) to head (8b193d7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3298   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files          20       20           
  Lines        6076     6076           
=======================================
  Hits         5583     5583           
  Misses        493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf force-pushed the Gvp53yva2aqbllig3wjytgakvxxqrmdhx branch from bf7d991 to 2442237 Compare April 19, 2026 16:03
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf
Copy link
Copy Markdown
Member Author

joshlf commented Apr 19, 2026

@Kha I'm incrementally landing parts of #3297, with you listed in the Co-authored-by: git commit message trailer. Google is requiring you to sign the CLA before I can land this. Lmk if you're comfortable doing that, or if you'd prefer I just land these w/o Co-authored-by: (I can still credit you in a less structured way).

@Kha
Copy link
Copy Markdown

Kha commented Apr 19, 2026

@joshlf no need for coauthorship from my side, I didn't even look at most of the changes!

…neration

This change incrementally adopts the Lake artifact cache for integration tests
and workspace generation, avoiding redundant clones and builds.

- During setup, populates Lake's artifact cache in the toolchain directory.
- During workspace generation, copies lake-manifest.json from the
  toolchain and patches it to include the aeneas dependency.
- Symlinks the toolchain's .lake/packages directory into the generated
  workspace to share source checkouts.

gherrit-pr-id: Gvp53yva2aqbllig3wjytgakvxxqrmdhx
@joshlf joshlf force-pushed the Gvp53yva2aqbllig3wjytgakvxxqrmdhx branch from 2442237 to 8b193d7 Compare April 19, 2026 16:14
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants